Prev: regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()
Next: mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
From: Axel Lin on 9 Aug 2010 05:10
i2c_smbus_write_byte_data() returns zero or negative value,
therefore no need to check if ret is greater than zero or not.

Signed-off-by: Axel Lin <axel.lin(a)gmail.com>
Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com>
---
drivers/regulator/lp3971.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
index 8ae3732..d4d9822 100644
--- a/drivers/regulator/lp3971.c
+++ b/drivers/regulator/lp3971.c
@@ -387,15 +387,9 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count,
static int lp3971_i2c_write(struct i2c_client *i2c, char reg, int count,
const u16 *src)
{
- int ret;
-
if (count != 1)
return -EIO;
- ret = i2c_smbus_write_byte_data(i2c, reg, *src);
- if (ret >= 0)
- return 0;
-
- return ret;
+ return i2c_smbus_write_byte_data(i2c, reg, *src);
}

static u8 lp3971_reg_read(struct lp3971 *lp3971, u8 reg)
--
1.5.4.3



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()
Next: mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler