regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()
in [Kernel]
|
Prev: Add quick erase format option
Next: [PATCH RESEND again] regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()
From: Axel Lin on 9 Aug 2010 05:10 2010/8/9 Liam Girdwood <lrg(a)slimlogic.co.uk>: > On Fri, 2010-08-06 at 08:09 +0800, Axel Lin wrote: >> We already check count value before calling i2c_smbus_read_byte_data(), >> no need to check it again. >> >> Signed-off-by: Axel Lin <axel.lin(a)gmail.com> >> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> >> --- >> This resend adds regulator: prefix in the subject line. >> >> �drivers/regulator/lp3971.c | � �2 +- >> �1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c >> index d4d9822..3bb82b6 100644 >> --- a/drivers/regulator/lp3971.c >> +++ b/drivers/regulator/lp3971.c >> @@ -377,7 +377,7 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count, >> � � � if (count != 1) >> � � � � � � � return -EIO; >> � � � ret = i2c_smbus_read_byte_data(i2c, reg); >> - � � if (ret < 0 || count != 1) >> + � � if (ret < 0) >> � � � � � � � return -EIO; >> >> � � � *dest = ret; > > Applied 1/2 only as 2/2 is the same patch. Ooops. My bad. I copied the same patch for patch 1/2 and 1/2. I'll resend it now. patch tiltle: [PATCH RESEND again] regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write() Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |