oom: introduce find_lock_task_mm() to fix !mm false positives
in [Kernel]
|
Prev: various OOM fixes for 2.6.35
Next: [PATCH] - race-free suspend. Was: Re: [PATCH 0/8] Suspend block api (version 8)
From: Minchan Kim on 3 Jun 2010 02:20 On Thu, Jun 3, 2010 at 2:50 PM, KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> wrote: > From: Oleg Nesterov <oleg(a)redhat.com> > > Almost all ->mm == NUL checks in oom_kill.c are wrong. > > The current code assumes that the task without ->mm has already > released its memory and ignores the process. However this is not > necessarily true when this process is multithreaded, other live > sub-threads can use this ->mm. > > - Remove the "if (!p->mm)" check in select_bad_process(), it is > just wrong. > > - Add the new helper, find_lock_task_mm(), which finds the live > thread which uses the memory and takes task_lock() to pin ->mm > > - change oom_badness() to use this helper instead of just checking > ->mm != NULL. > > - As David pointed out, select_bad_process() must never choose the > task without ->mm, but no matter what badness() returns the > task can be chosen if nothing else has been found yet. > > Note! This patch is not enough, we need more changes. > > - badness() was fixed, but oom_kill_task() still ignores > the task without ->mm > > This will be addressed later. > > Signed-off-by: Oleg Nesterov <oleg(a)redhat.com> > Cc: David Rientjes <rientjes(a)google.com> > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> Could you see my previous comment? http://lkml.org/lkml/2010/6/2/325 Anyway, I added my review sign Reviewed-by: Minchan Kim <minchan.kim(a)gmail.com> -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |