padata: section cleanup
in [Kernel]
|
From: Steffen Klassert on 29 Mar 2010 04:10 On Sat, Mar 27, 2010 at 07:53:46AM +0100, Henrik Kretzschmar wrote: > This patch removes the __cupinit from padata_cpu_callback(), > which is refered by the exportet function padata_alloc(). > > This could lead to problems if CONFIG_HOTPLUG_CPU is disabled, > which should happen very often. > > WARNING: kernel/built-in.o(.text+0x7ffcb): Section mismatch in reference from the function padata_alloc() to the function .cpuinit.text:padata_cpu_callback() > The function padata_alloc() references > the function __cpuinit padata_cpu_callback(). > This is often because padata_alloc lacks a __cpuinit > annotation or the annotation of padata_cpu_callback is wrong. > > Signed-off-by: Henrik Kretzschmar <henne(a)nachtwindheim.de> Acked-by: Steffen Klassert <steffen.klassert(a)secunet.com> Thanks, Steffen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Herbert Xu on 29 Mar 2010 04:20 On Sat, Mar 27, 2010 at 07:53:46AM +0100, Henrik Kretzschmar wrote: > This patch removes the __cupinit from padata_cpu_callback(), > which is refered by the exportet function padata_alloc(). > > This could lead to problems if CONFIG_HOTPLUG_CPU is disabled, > which should happen very often. > > WARNING: kernel/built-in.o(.text+0x7ffcb): Section mismatch in reference from the function padata_alloc() to the function .cpuinit.text:padata_cpu_callback() > The function padata_alloc() references > the function __cpuinit padata_cpu_callback(). > This is often because padata_alloc lacks a __cpuinit > annotation or the annotation of padata_cpu_callback is wrong. > > Signed-off-by: Henrik Kretzschmar <henne(a)nachtwindheim.de> Patch applied. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert(a)gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Herbert Xu on 31 Mar 2010 21:40 On Wed, Mar 31, 2010 at 06:04:45PM -0400, Andrew Morton wrote: > > I can find it once, in December 2009, in the middle of a massive thread > called "workqueue thing". It had no replies. OK you're right. It's only been posted to lkml once. However, this has been discussed on netdev since 2008 at least. The patch in its current form has also been acked by David Miller. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert(a)gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 31 Mar 2010 23:40 On Thu, 1 Apr 2010 09:38:45 +0800 Herbert Xu <herbert(a)gondor.apana.org.au> wrote: > On Wed, Mar 31, 2010 at 06:04:45PM -0400, Andrew Morton wrote: > > > > I can find it once, in December 2009, in the middle of a massive thread > > called "workqueue thing". It had no replies. > > OK you're right. It's only been posted to lkml once. However, > this has been discussed on netdev since 2008 at least. The patch > in its current form has also been acked by David Miller. > Thing is, this isn't net code and it isn't crypto code - it's a kernel-wide utility. Everyone needs to know at least a bit about it and code-reviewers such as myself need to know a lot about it, so we can tell people "hey dummy, shouldn't you use padata". So please, can we belatedly go through the process of educating the developers about this thing you guys have written for us? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 1 Apr 2010 03:20 From: Andrew Morton <akpm(a)linux-foundation.org> Date: Wed, 31 Mar 2010 20:29:31 -0400 > Thing is, this isn't net code and it isn't crypto code - it's a > kernel-wide utility. Thanks goodness, because if we had put a private copy in the networking or the crypto code someone would have given us a hard time. Wait a second... we're being given a hard time anyways. :-) Kidding aside, why didn't anyone show any interest in the patch when it was posted to lkml? You can say it was smoothered together with some crypto stuff, but that was absolutely the logical thing to do because the follow-on crypto patches showed what the thing was going to be used for. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Next
|
Last
Pages: 1 2 3 Prev: [PATCH] [REGRESSION 2.6.33] x86: Handle overlapping mptables Next: [PATCH] /fs/cifs HEAD |