perf: Fix endianness argument compatibility with OPT_BOOLEAN() and introduce OPT_INCR()
in [Kernel]
|
Prev: MacBookPro2,2 unable too boot with the latest HEAD
Next: [PATCH 1/2] input: Add support of Synaptics Clickpad device
From: Erik Faye-Lund on 14 Apr 2010 11:20 I'd just like to point out that I'm commenting from the Git pont-of-view, since this patch was CC'ed to the Git mailing-list. On Wed, Apr 14, 2010 at 11:36 AM, tip-bot for Ian Munsie <imunsie(a)au.ibm.com> wrote: > Commit-ID: �c05556421742eb47f80301767653a4bcb19de9de > Gitweb: � � http://git.kernel.org/tip/c05556421742eb47f80301767653a4bcb19de9de > Author: � � Ian Munsie <imunsie(a)au.ibm.com> > AuthorDate: Tue, 13 Apr 2010 18:37:33 +1000 > Committer: �Ingo Molnar <mingo(a)elte.hu> > CommitDate: Wed, 14 Apr 2010 11:26:44 +0200 > > perf: Fix endianness argument compatibility with OPT_BOOLEAN() and introduce OPT_INCR() > > Parsing an option from the command line with OPT_BOOLEAN on a > bool data type would not work on a big-endian machine due to the > manner in which the boolean was being cast into an int and > incremented. We don't use C99 features like the "bool"-type in Git, so this shouldn't really be a problem in our end. > For example, running 'perf probe --list' on a > PowerPC machine would fail to properly set the list_events bool > and would therefore print out the usage information and > terminate. > I don't know what this 'perf'-thing is, but it sounds like it's some external client for the parse-options-API that uses OPT_BOOLEAN incorrectly. Looking at linux-next.git, it seems so. The code in tools/perf/ seems to use OPT_BOOLEAN with C99 bools, and it seems to have imported git's parse-options API (in commit 0780060124011b94af55830939c86cc0916be0f5, it seems). I'd suggest either fixing the call-sites to use int, or just keeping these changes in linux-next.git. -- Erik "kusma" Faye-Lund -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |