posix-timers: Refactoring of CPUCLOCK* macros
in [Kernel]
|
Prev: [PATCH 21/26] cciss: sanitize max commands
Next: [PATCH 10/26] cciss: factor out cciss_find_board_params
From: Daniel Walker on 19 Jul 2010 14:50 On Mon, 2010-07-19 at 13:34 +0200, Tomasz Buchert wrote: > This is merely a preparation to introduce wall time > clocks for threads/processes. All occurences of > CPUCLOCK* macros were replaced by CLOCK*. It seems like it would be better to make this naming more specific that less. Couldn't you say "POSIX_CLOCK" or something like that? Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Tomasz Buchert on 19 Jul 2010 17:00 Daniel Walker a écrit : > On Mon, 2010-07-19 at 13:34 +0200, Tomasz Buchert wrote: >> This is merely a preparation to introduce wall time >> clocks for threads/processes. All occurences of >> CPUCLOCK* macros were replaced by CLOCK*. > > It seems like it would be better to make this naming more specific that > less. Couldn't you say "POSIX_CLOCK" or something like that? > > Daniel Hi Daniel. Sure. However, technically, my wall clocks have nothing to do with POSIX. Still the code is inside a file with "posix" prefix, so you are right. I will resend patch series as soon as it is done. Could you elaborate on another patches? Tomek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Daniel Walker on 19 Jul 2010 17:10 On Mon, 2010-07-19 at 22:59 +0200, Tomasz Buchert wrote: > Daniel Walker a écrit : > > On Mon, 2010-07-19 at 13:34 +0200, Tomasz Buchert wrote: > >> This is merely a preparation to introduce wall time > >> clocks for threads/processes. All occurences of > >> CPUCLOCK* macros were replaced by CLOCK*. > > > > It seems like it would be better to make this naming more specific that > > less. Couldn't you say "POSIX_CLOCK" or something like that? > > > > Daniel > Hi Daniel. > Sure. However, technically, my wall clocks have nothing to do > with POSIX. Still the code is inside a file with "posix" prefix, > so you are right. > I will resend patch series as soon as it is done. Could you > elaborate on another patches? I wasn't suggesting that adding "POSIX" is the only option, but adding something more so it's not just "CLOCK" . You mean you want me to review the other patches also ? Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Tomasz Buchert on 19 Jul 2010 17:20
Daniel Walker a écrit : > On Mon, 2010-07-19 at 22:59 +0200, Tomasz Buchert wrote: >> Daniel Walker a écrit : >>> On Mon, 2010-07-19 at 13:34 +0200, Tomasz Buchert wrote: >>>> This is merely a preparation to introduce wall time >>>> clocks for threads/processes. All occurences of >>>> CPUCLOCK* macros were replaced by CLOCK*. >>> It seems like it would be better to make this naming more specific that >>> less. Couldn't you say "POSIX_CLOCK" or something like that? >>> >>> Daniel >> Hi Daniel. >> Sure. However, technically, my wall clocks have nothing to do >> with POSIX. Still the code is inside a file with "posix" prefix, >> so you are right. >> I will resend patch series as soon as it is done. Could you >> elaborate on another patches? > > I wasn't suggesting that adding "POSIX" is the only option, but adding > something more so it's not just "CLOCK" . > > You mean you want me to review the other patches also ? > > Daniel > "POSIX" looks good to me. Reviewing the other patches would be great, because they actually do real stuff. Tomek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |