From: Samuel Ortiz on
On Tue, Jul 20, 2010 at 03:57:38PM +0900, Joonyoung Shim wrote:
> This adds support for the RTC provided by the Maxim 8998 chip. This
> driver was tested on a GONI board by using the rtc-test application from
> the Documentation/rtc.txt.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com>
For the mfd part:
Acked-by: Samuel Ortiz <sameo(a)linux.intel.com>

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Rabin Vincent on
On Tue, Jul 20, 2010 at 03:57:38PM +0900, Joonyoung Shim wrote:
> diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> index 7e4489f..0612851 100644
> --- a/drivers/mfd/max8998.c
> +++ b/drivers/mfd/max8998.c
> @@ -30,9 +30,12 @@
> #include <linux/mfd/max8998.h>
> #include <linux/mfd/max8998-private.h>
>
> +#define RTC_I2C_ADDR (0x0c >> 1)
> +
> static struct mfd_cell max8998_devs[] = {
> {
> .name = "max8998-pmic",
> + .name = "max8998-rtc",
> }
> };

Missing braces?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Alessandro Zummo on
On Mon, 02 Aug 2010 16:35:07 +0900
Joonyoung Shim <jy0922.shim(a)samsung.com> wrote:

> This adds support for the RTC provided by the Maxim 8998 chip. This
> driver was tested on a GONI board by using the rtc-test application from
> the Documentation/rtc.txt.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com>
> Acked-by: Samuel Ortiz <sameo(a)linux.intel.com>

Seems nice. I'd add rtc_valid_tm where appropriate.
And maybe free that irq you requested ;)

pending those changes, you have my

Acked-by: Alessandro Zummo <a.zummo(a)towertech.it>


--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Joonyoung Shim on
On 8/3/2010 9:08 AM, Alessandro Zummo wrote:
> On Mon, 02 Aug 2010 16:35:07 +0900
> Joonyoung Shim <jy0922.shim(a)samsung.com> wrote:
>
>> This adds support for the RTC provided by the Maxim 8998 chip. This
>> driver was tested on a GONI board by using the rtc-test application from
>> the Documentation/rtc.txt.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com>
>> Acked-by: Samuel Ortiz <sameo(a)linux.intel.com>
>
> Seems nice. I'd add rtc_valid_tm where appropriate.
> And maybe free that irq you requested ;)
>

Right, i missed.

> pending those changes, you have my
>
> Acked-by: Alessandro Zummo <a.zummo(a)towertech.it>
>
>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/