Prev: enable readback to get HPET working on ATI SB4x00, kernel 2.6.35_rc5
Next: xfs: don't block on buffer read errors
From: Joe Perches on 14 Jul 2010 14:30
On Wed, 2010-07-14 at 22:05 +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index 8d16380..8b49cb1 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
>
> for (i = 0; i < len; i++) {
> if (i % 16 == 0)
> - printk("\n0x%08x:", (unsigned int)cptr);
> + printk("\n%p:", cptr);
>
> printk(" %02x", *(cptr++));
> }

I was originally going to suggest a conversion
to print_hex_dump, but this function isn't used
and it and daqp_dump might as well be removed.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 14 Jul 2010 17:00
On Wed, Jul 14, 2010 at 10:05:17PM +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-

Why does your Subject: say "msm"?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Daniel Walker on 14 Jul 2010 18:30
On Wed, 2010-07-14 at 15:28 -0700, David Brown wrote:
> On Wednesday 14 July 2010 11:05:58 Kulikov Vasiliy wrote:
>
> > Use %p instead of %08x in printk().
> >
> > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
>
> Acked-by: David Brown <davidb(a)codeaurora.org>

yeah, it looks fine to me too.

Daniel

--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Brown on 14 Jul 2010 18:30
On Wednesday 14 July 2010 11:05:58 Kulikov Vasiliy wrote:

> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>

Acked-by: David Brown <davidb(a)codeaurora.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Brown on 14 Jul 2010 18:40
On Wednesday 14 July 2010 11:05:17 Kulikov Vasiliy wrote:

> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-

Did you mean to have an 'msm:' in the subject? This driver isn't part
of the msm subsystem?

Thanks,
David Brown

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: enable readback to get HPET working on ATI SB4x00, kernel 2.6.35_rc5
Next: xfs: don't block on buffer read errors