xfs: don't block on buffer read errors
in [Kernel]
|
Prev: staging: msm: formatting of pointers in printk()
Next: [PATCH -v2] x86: only set early_serial_base after port is initialized in setup code
From: Christoph Hellwig on 14 Jul 2010 14:30 Looks good, except that I'd rework the snipplet below > status = xfs_buf_iorequest(bp); > - if (!status && !(flags & XBF_ASYNC)) > + if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))) > status = xfs_buf_iowait(bp); > return status; as: if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)) return status; return xfs_buf_iowait(bp); to make it a bit more clear. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dave Chinner on 14 Jul 2010 20:10
On Wed, Jul 14, 2010 at 02:28:36PM -0400, Christoph Hellwig wrote: > Looks good, except that I'd rework the snipplet below > > > status = xfs_buf_iorequest(bp); > > - if (!status && !(flags & XBF_ASYNC)) > > + if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))) > > status = xfs_buf_iowait(bp); > > return status; > > as: > > if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)) > return status; > return xfs_buf_iowait(bp); > > to make it a bit more clear. Make sense. Fixed it up. Cheers, Dave. -- Dave Chinner david(a)fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |