Prev: staging: winbond: wb35rx.c Coding style fixes v2.
Next: video/sn9c102: improve error handling
From: Christophe JAILLET on 28 Mar 2010 11:10
Hi,

this patch seems incomplet.

You had an opening { whitout the corresponding }.

Best regards,
Christophe Jaillet

"Dan Carpenter" <error27(a)gmail.com> a �crit
dans le message de news:20100328114945.GV5069(a)bicker...
> The original code doesn't handle the situation where the controller is
> not found.
>
> Signed-off-by: Dan Carpenter
<error27(a)gmail.com>
>
> diff --git a/drivers/media/video/et61x251/et61x251_core.c
b/drivers/media/video/et61x251/et61x251_core.c
> index e6c23d5..a5cfc76 100644
> --- a/drivers/media/video/et61x251/et61x251_core.c
> +++ b/drivers/media/video/et61x251/et61x251_core.c
> @@ -1713,7 +1713,7 @@ et61x251_vidioc_s_ctrl(struct et61x251_device* cam,
void __user * arg)
> if (copy_from_user(&ctrl, arg, sizeof(ctrl)))
> return -EFAULT;
>
> - for (i = 0; i < ARRAY_SIZE(s->qctrl); i++)
> + for (i = 0; i < ARRAY_SIZE(s->qctrl); i++) {
> if (ctrl.id == s->qctrl[i].id) {
> if (s->qctrl[i].flags & V4L2_CTRL_FLAG_DISABLED)
> return -EINVAL;
> @@ -1723,7 +1723,9 @@ et61x251_vidioc_s_ctrl(struct et61x251_device* cam,
void __user * arg)
> ctrl.value -= ctrl.value % s->qctrl[i].step;
> break;
> }



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: staging: winbond: wb35rx.c Coding style fixes v2.
Next: video/sn9c102: improve error handling