Prev: video/et61x251: improve error handling
Next: [PATCH] fs/btrfs: Correct use after free
From: Christophe JAILLET on 28 Mar 2010 11:20
Hi,

this patch seems incomplete.

You had an opening { wityhout the corresponding }.

Best regards,
Christophe Jaillet.

"Dan Carpenter" <error27(a)gmail.com> a �crit
dans le message de news:20100328115005.GW5069(a)bicker...
> Return an error if the controller is not found.
>
> Signed-off-by: Dan Carpenter
<error27(a)gmail.com>
>
> diff --git a/drivers/media/video/sn9c102/sn9c102_core.c
b/drivers/media/video/sn9c102/sn9c102_core.c
> index cbf8087..28e19da 100644
> --- a/drivers/media/video/sn9c102/sn9c102_core.c
> +++ b/drivers/media/video/sn9c102/sn9c102_core.c
> @@ -2295,7 +2295,7 @@ sn9c102_vidioc_s_ctrl(struct sn9c102_device* cam,
void __user * arg)
> if (copy_from_user(&ctrl, arg, sizeof(ctrl)))
> return -EFAULT;
>
> - for (i = 0; i < ARRAY_SIZE(s->qctrl); i++)
> + for (i = 0; i < ARRAY_SIZE(s->qctrl); i++) {
> if (ctrl.id == s->qctrl[i].id) {
> if (s->qctrl[i].flags & V4L2_CTRL_FLAG_DISABLED)
> return -EINVAL;
> @@ -2305,7 +2305,9 @@ sn9c102_vidioc_s_ctrl(struct sn9c102_device* cam,
void __user * arg)
> ctrl.value -= ctrl.value % s->qctrl[i].step;
> break;
> }



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Dan Carpenter on 28 Mar 2010 11:40
On Sun, Mar 28, 2010 at 05:09:48PM +0200, Christophe JAILLET wrote:
> Hi,
>
> this patch seems incomplete.
>
> You had an opening { wityhout the corresponding }.

It must be an issue with the mail server on your end. :/

Here is a url you can download it from.
http://lkml.org/lkml/2010/3/28/43

Unfortunately, lkml.org puts some white space on the end of diffs.
Patch complains but it still applies them fine.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: video/et61x251: improve error handling
Next: [PATCH] fs/btrfs: Correct use after free