watchdog: Add watchdog driver for OCTEON SOCs (v2).
in [Kernel]
|
Prev: a Great Idea - include Kademlia networking protocol in kernel
Next: cris: gpio: do not call copy_to_user()/copy_from_user() while holding spinlocks
From: Wim Van Sebroeck on 2 Aug 2010 08:40 Hi David, Ralf, > The OCTEON is a MIPS64 based SOC family with an on chip watchdog unit. > > The driver is split into two source files one for the C code and one > for assembly. Assembly is needed to handle the NMI and then print the > machine state before the reboot is triggered. > > v2: Stylistic changes suggested by Sam Ravnborg. This v2 looks good. only small remark is: > +static struct notifier_block octeon_wdt_cpu_notifier = { > + .notifier_call = octeon_wdt_cpu_callback > +}; Add a comma after octeon_wdt_cpu_callback. > Signed-off-by: David Daney <ddaney(a)caviumnetworks.com> > Cc: Wim Van Sebroeck <wim(a)iguana.be> Signed-off-by: Wim Van Sebroeck <wim(a)iguana.be> > Cc: Andrew Morton <akpm(a)linux-foundation.org> > Cc: Russell King <rmk+kernel(a)arm.linux.org.uk> > Cc: Tony Lindgren <tony(a)atomide.com> > Cc: Marc Zyngier <maz(a)misterjones.org> > Cc: Thierry Reding <thierry.reding(a)avionic-design.de> > Cc: Sam Ravnborg <sam(a)ravnborg.org> Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ralf Baechle on 2 Aug 2010 09:00
On Mon, Aug 02, 2010 at 02:37:55PM +0200, Wim Van Sebroeck wrote: > > Signed-off-by: David Daney <ddaney(a)caviumnetworks.com> > > Cc: Wim Van Sebroeck <wim(a)iguana.be> > > Signed-off-by: Wim Van Sebroeck <wim(a)iguana.be> Patch updated. Thanks Wim! Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |