From: Pekka Enberg on
On Tue, Jul 13, 2010 at 11:35 PM, Yinghai Lu <yinghai(a)kernel.org> wrote:
> [PATCH] x86: make boot code to analyze console=uart8250 too
>
> So we use console=uart8250,io,0x2f8,115200n all the way
>
> Also add back simple_guess_base(), otherwise those simple_strtoull(,,0) are not
> going to work.
>
> Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>

Cool! Thanks Yinghai!

Acked-by: Pekka Enberg <penberg(a)cs.helsinki.fi>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on
On Tue, 03 Aug 2010 00:14:38 -0700 Yinghai Lu <yinghai(a)kernel.org> wrote:

>
> Analyze "console=uart8250,io,0x3f8,115200n8" in i386_start_kernel/x86_64_start_kernel,
> and call setup_early_serial8250_console() to init early serial console.
>
> only can handle io port kind of 8250. because mmio need ioremap.
>
> -v2: use boot_params.hdr.version instead of adding another variable, Suggested by hpa
> update after using x86 memblock patchset
> -v3: x86 memblock can not make into with 2.6.36 now
> so update this patch to be applied before x86 memblock patchset again.
>
> ...
>
> --- linux-2.6.orig/kernel/printk.c
> +++ linux-2.6/kernel/printk.c
> @@ -1203,6 +1203,10 @@ void register_console(struct console *ne
> if (console_drivers && newcon->flags & CON_BOOT) {
> /* find the last or real console */
> for_each_console(bcon) {
> + /* not again */
> + if (bcon == newcon)
> + return;
> +
> if (!(bcon->flags & CON_BOOT)) {
> printk(KERN_INFO "Too late to register bootconsole %s%d\n",

Why this change?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on
On 08/03/2010 02:06 AM, Andrew Morton wrote:
> On Tue, 03 Aug 2010 00:14:38 -0700 Yinghai Lu <yinghai(a)kernel.org> wrote:
>
>>
>> Analyze "console=uart8250,io,0x3f8,115200n8" in i386_start_kernel/x86_64_start_kernel,
>> and call setup_early_serial8250_console() to init early serial console.
>>
>> only can handle io port kind of 8250. because mmio need ioremap.
>>
>> -v2: use boot_params.hdr.version instead of adding another variable, Suggested by hpa
>> update after using x86 memblock patchset
>> -v3: x86 memblock can not make into with 2.6.36 now
>> so update this patch to be applied before x86 memblock patchset again.
>>
>> ...
>>
>> --- linux-2.6.orig/kernel/printk.c
>> +++ linux-2.6/kernel/printk.c
>> @@ -1203,6 +1203,10 @@ void register_console(struct console *ne
>> if (console_drivers && newcon->flags & CON_BOOT) {
>> /* find the last or real console */
>> for_each_console(bcon) {
>> + /* not again */
>> + if (bcon == newcon)
>> + return;
>> +
>> if (!(bcon->flags & CON_BOOT)) {
>> printk(KERN_INFO "Too late to register bootconsole %s%d\n",
>
> Why this change?

it seems register the same console as early console will dead loop.

let me double check that again to see if can remove that change.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on
On 08/03/2010 02:06 AM, Andrew Morton wrote:
> On Tue, 03 Aug 2010 00:14:38 -0700 Yinghai Lu <yinghai(a)kernel.org> wrote:
>
>>
>> Analyze "console=uart8250,io,0x3f8,115200n8" in i386_start_kernel/x86_64_start_kernel,
>> and call setup_early_serial8250_console() to init early serial console.
>>
>> only can handle io port kind of 8250. because mmio need ioremap.
>>
>> -v2: use boot_params.hdr.version instead of adding another variable, Suggested by hpa
>> update after using x86 memblock patchset
>> -v3: x86 memblock can not make into with 2.6.36 now
>> so update this patch to be applied before x86 memblock patchset again.
>>
>> ...
>>
>> --- linux-2.6.orig/kernel/printk.c
>> +++ linux-2.6/kernel/printk.c
>> @@ -1203,6 +1203,10 @@ void register_console(struct console *ne
>> if (console_drivers && newcon->flags & CON_BOOT) {
>> /* find the last or real console */
>> for_each_console(bcon) {
>> + /* not again */
>> + if (bcon == newcon)
>> + return;
>> +
>> if (!(bcon->flags & CON_BOOT)) {
>> printk(KERN_INFO "Too late to register bootconsole %s%d\n",
>
> Why this change?

without that will get

early console in setup code
early console in decompress_kernel
decompress_kernel:
input: [0x24a0269-0x2e8b642], output: 0x1000000, heap: [0x2e90e40-0x2e97e3f]

Decompressing Linux... Parsing ELF... done.
Booting the kernel.
[ 0.000000] bootconsole [uart0] enabled
[ 0.000000] Kernel Layout:
[ 0.000000] .text: [0x01000000-0x01cb210d]
[ 0.000000] .rodata: [0x01cb8000-0x02419fff]
[ 0.000000] .data: [0x0241a000-0x025b583f]
[ 0.000000] .init: [0x025b7000-0x02875fff]
[ 0.000000] .bss: [0x02880000-0x0348bb6f]
[ 0.000000] .brk: [0x0348c000-0x034abfff]
[ 0.000000] memblock_x86_reserve_range: [0x01000000-0x0348bb6f] TEXT DATA BSS
[ 0.000000] memblock_x86_reserve_range: [0x2c6b0000-0x2ffcefff] RAMDISK
[ 0.000000] memblock_x86_reserve_range: [0x0009fc00-0x000fffff] * BIOS reserved
[ 0.000000] Initializing cgroup subsys cpuset
[ 0.000000] Initializing cgroup subsys cpu
[ 0.000000] Linux version 2.6.35-tip-yh-01758-g649ef4b-dirty (yhlu(a)linux-siqj) (gcc version 4.4.1 [gcc-4_4-branch revision 150839] (SUSE Linux) ) #148 SMP Tue Aug 3 03:09:06 PDT 2010
[ 0.000000] Command line: BOOT_IMAGE=linux debug apic=debug ramdisk_size=262144 root=/dev/ram0 rw ip=dhcp console=uart8250,io,0x3f8,115200 initrd=initrd.img
[ 0.000000] KERNEL supported cpus:
[ 0.000000] Intel GenuineIntel
[ 0.000000] AMD AuthenticAMD
[ 0.000000] Centaur CentaurHauls
[ 0.000000] BIOS-provided physical RAM map:
[ 0.000000] BIOS-e820: [0x00000000000000-0x0000000009efff] (usable)
[ 0.000000] BIOS-e820: [0x0000000009f000-0x0000000009ffff] (reserved)
[ 0.000000] BIOS-e820: [0x000000000e8000-0x000000000fffff] (reserved)
[ 0.000000] BIOS-e820: [0x00000000100000-0x0000002ffeffff] (usable)
[ 0.000000] BIOS-e820: [0x0000002fff0000-0x0000002fffffff] (ACPI data)
[ 0.000000] BIOS-e820: [0x000000fffbc000-0x000000ffffffff] (reserved)
[ 0.000000] Early serial console at I/O port 0x3f8 (options '115200')
[ 0.000000] Early serial console at I/O port 0x3f8 (options '115200')
[ 0.000000] Early serial console at I/O port 0x3f8 (options '115200')
[ 0.000000] Early serial console at I/O port 0x3f8 (options '115200')
.....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Cyrill Gorcunov on
On Tue, Aug 03, 2010 at 12:14:38AM -0700, Yinghai Lu wrote:
>
> Analyze "console=uart8250,io,0x3f8,115200n8" in i386_start_kernel/x86_64_start_kernel,
> and call setup_early_serial8250_console() to init early serial console.
>
> only can handle io port kind of 8250. because mmio need ioremap.
>
> -v2: use boot_params.hdr.version instead of adding another variable, Suggested by hpa
> update after using x86 memblock patchset
> -v3: x86 memblock can not make into with 2.6.36 now
> so update this patch to be applied before x86 memblock patchset again.
>
> Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>
> ---

Looks good to me, thanks Yinghai!

-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/