Config NO_BOOTMEM breaks my amd64 box
in [Kernel]
|
From: H. Peter Anvin on 31 Mar 2010 20:40 On 03/31/2010 04:54 PM, Yinghai Lu wrote: > > --- > mm/bootmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/mm/bootmem.c > =================================================================== > --- linux-2.6.orig/mm/bootmem.c > +++ linux-2.6/mm/bootmem.c > @@ -303,7 +303,7 @@ unsigned long __init free_all_bootmem_no > unsigned long __init free_all_bootmem(void) > { > #ifdef CONFIG_NO_BOOTMEM > - return free_all_memory_core_early(NODE_DATA(0)->node_id); > + return free_all_memory_core_early(MAX_NUMNODES); > #else > return free_all_bootmem_core(NODE_DATA(0)->bdata); > #endif > >> >> Furthermore, I really don't see the connection between this and James >> Morris' reported problem, which he reports as "amd64", which presumably >> is an x86-64 kernel and not 32 bits... James, is that correct? Any >> more details you can give about the system? I *really* don't want to go >> into cargo cult programming mode, that would suck eggs no matter what. > > it happened one of my test setup, node0 ram disappear somehow. > and i found the 32bit numa doesn't work on that. > .... which is useful and valid, but I still think this isn't related to James' problem, if James' problem wasn't actually fixed in -rc3. That's the part that I'm afraid I have to be confused about... all the known problems except the above are fixed in -rc3, and I'd at least like to have a validated bug report of any sort before saying it should all be tossed. This patch looks a lot better. The whole use of MAX_NUMNODES as a sentinel (which appears inherited from mm/page_alloc.c, and as such is a pre-existing convention which is also invoked here) really could use a comment, though. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on 31 Mar 2010 21:10 On 03/31/2010 05:35 PM, H. Peter Anvin wrote: > On 03/31/2010 04:54 PM, Yinghai Lu wrote: > > This patch looks a lot better. The whole use of MAX_NUMNODES as a > sentinel (which appears inherited from mm/page_alloc.c, and as such is a > pre-existing convention which is also invoked here) really could use a > comment, though. sure. will have updated one with coments there Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: James Morris on 31 Mar 2010 21:10 On Wed, 31 Mar 2010, H. Peter Anvin wrote: > On 03/31/2010 04:43 PM, James Morris wrote: > >> > >> Upgraded how? The problem no longer happens? > > > > Upgraded to the latest rawhide userland -- I have not since tested with > > bootmem off. I'll try and do so again when I get a chance. > > > > That would be great. The sooner the better, obviously. I'm not seeing any problems now, with current Linus and rawhide. I'll leave bootmem off and see if anything comes up again. -- James Morris <jmorris(a)namei.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 31 Mar 2010 23:30 OK... I think I'm going to write this up as unconfirmed... which means the only known problem that was not addressed in rc3 is the 32-bit NUMA issue, which we have a bug for. Linus: does this address your concerns for now, or do you still want us to revert? "James Morris" <jmorris(a)namei.org> wrote: >On Wed, 31 Mar 2010, H. Peter Anvin wrote: > >> On 03/31/2010 04:43 PM, James Morris wrote: >> >> >> >> Upgraded how? The problem no longer happens? >> > >> > Upgraded to the latest rawhide userland -- I have not since tested with >> > bootmem off. I'll try and do so again when I get a chance. >> > >> >> That would be great. The sooner the better, obviously. > >I'm not seeing any problems now, with current Linus and rawhide. I'll >leave bootmem off and see if anything comes up again. > > >-- >James Morris ><jmorris(a)namei.org> -- Sent from my mobile phone, pardon any lack of formatting.
From: Yinghai Lu on 31 Mar 2010 23:40
On 03/31/2010 08:16 PM, H. Peter Anvin wrote: > OK... I think I'm going to write this up as unconfirmed... which means the only known problem that was not addressed in rc3 is the 32-bit NUMA issue, which we have a bug for. > the 32 bit numa problem is one edge case (node0 doesn't have memory installed), and the problem has been there for a while before we introduce NO_BOOTMEM support. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |