Kernel

writeback: prevent unnecessary bdi threads wakeups
> + if (wb_has_dirty_io(wb) && dirty_writeback_interval) { + unsigned long wait; - wait_jiffies = msecs_to_jiffies(dirty_writeback_interval * 10); - schedule_timeout(wait_jiffies); + wait = msecs_to_jiffies(dirty_writeback_interval * 10); + schedule_timeout(wait); No need for a local v... 23 Jul 2010 11:23

Mtd: fixed coding style indent errors
On Sun, 2010-07-11 at 21:46 -0500, Neal B wrote: From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001 From: Neal Buckendahl <nealb001(a)gmail.com> Date: Sun, 11 Jul 2010 16:58:24 -0500 Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the checkpatch.pl tool Signed-... 18 Jul 2010 04:08

writeback: move bdi threads exiting logic to the forker thread
Yes, only killing threads from the caller is much better, that's how the kthread API is supposed to be used anyway. static void bdi_queue_work(struct backing_dev_info *bdi, struct wb_writeback_work *work) { + bool wakeup_default = false; + trace_writeback_queue(bdi, work); spin_loc... 25 Jul 2010 06:32

writeback: move last_active to bdi
Looks good, Reviewed-by: Christoph Hellwig <hch(a)lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ... 18 Jul 2010 04:08

writeback: clean-up the warning about non-registered bdi
Looks good, Reviewed-by: Christoph Hellwig <hch(a)lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ... 18 Jul 2010 04:08

writeback: add to bdi_list in the forker thread
What about never removing a bdi from bdi_list? If we have the correct checks for dirty_io and the task there's no need to ever remove a life bdi from the list. Just add it in bdi_register and remove it in bdi_unregister. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of... 20 Jul 2010 08:03

writeback: do not lose default bdi wake-ups
> This patch also removes strange comment about a temporary measure, because there is nothing temporary there - many FSes use default bdi. I don't think that's correct. We're not using default_backing_dev_info for filesystems anymore for various reasons. Look at the spread of private bdi initializations fo... 18 Jul 2010 03:04

writeback: do not lose wake-ups in the forker thread
Looks good, Reviewed-by: Christoph Hellwig <hch(a)lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ... 18 Jul 2010 03:04

writeback: simplify bdi code a little
Looks correct, but I would do this slightly different. Add a new bdi_writeback_start_thread helper, and then call it from the list walk as long as there are bdis that need a thread. Only break out of the loop once nothing needs to be done and then sleep. -- To unsubscribe from this list: send the line "unsubsc... 21 Jul 2010 09:08

writeback: do not lose wake-ups in bdi threads
Looks good, Reviewed-by: Christoph Hellwig <hch(a)lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ... 18 Jul 2010 03:04