From: Jeremy Allison on
On Wed, Apr 07, 2010 at 11:20:38AM -0400, Chris Smith wrote:
> Any consensus or recommendations on whether or not to compile samba
> with pthreads and/or enabling the pthreadpool on a modern Linux
> distro?

The Samba code itself doesn't use pthreads directly, but
many of the subsystems it uses (eg. ldap, aio) do. So
you're almost certainly compiling with pthreads whether
you want to or not :-).

Jeremy.
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/options/samba
From: Chris Smith on
On Wed, Apr 7, 2010 at 1:55 PM, Jeremy Allison <jra(a)samba.org> wrote:
> The Samba code itself doesn't use pthreads directly, but
> many of the subsystems it uses (eg. ldap, aio) do. So
> you're almost certainly compiling with pthreads whether
> you want to or not :-).

So then:

--with-pthreads
--enable-pthreadpool

are recommended configure options?

Chris
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/options/samba
From: Jeremy Allison on
On Wed, Apr 07, 2010 at 02:35:18PM -0400, Chris Smith wrote:
> On Wed, Apr 7, 2010 at 1:55 PM, Jeremy Allison <jra(a)samba.org> wrote:
> > The Samba code itself doesn't use pthreads directly, but
> > many of the subsystems it uses (eg. ldap, aio) do. So
> > you're almost certainly compiling with pthreads whether
> > you want to or not :-).
>
> So then:
>
> --with-pthreads
> --enable-pthreadpool
>
> are recommended configure options?

Wow, haven't looked at the --enable-pthreadpool
code in a while :-). Yes, should work (although
I don't compile with it by default, I don't think
it has bit-rotted :-).

As always, test before enabling by default :-).

Jeremy.
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/options/samba
From: Volker Lendecke on
On Wed, Apr 07, 2010 at 11:45:14AM -0700, Jeremy Allison wrote:
> On Wed, Apr 07, 2010 at 02:35:18PM -0400, Chris Smith wrote:
> > On Wed, Apr 7, 2010 at 1:55 PM, Jeremy Allison <jra(a)samba.org> wrote:
> > > The Samba code itself doesn't use pthreads directly, but
> > > many of the subsystems it uses (eg. ldap, aio) do. So
> > > you're almost certainly compiling with pthreads whether
> > > you want to or not :-).
> >
> > So then:
> >
> > --with-pthreads
> > --enable-pthreadpool
> >
> > are recommended configure options?
>
> Wow, haven't looked at the --enable-pthreadpool
> code in a while :-). Yes, should work (although
> I don't compile with it by default, I don't think
> it has bit-rotted :-).

Well, the pthreadpool thingy not used right now. Feel free
to remove it, it's just a prototype API that wraps blocking
calls into tevent based async calls. The current prototype
implementation uses pthreads, but due to the performance
problems Samba has with the Linux pthreads implementation,
to put this to real use a clone-based implementation will
have to follow as well.

Volker