trivial: use (C) instead of \251
in [Kernel]
|
Prev: drivers/staging/rtl8192su: Hoist assign from if
Next: sched: implement the exclusive wait queue as a LIFO queue
From: Jiri Kosina on 30 Apr 2010 13:10 On Fri, 30 Apr 2010, Ingo Molnar wrote: > > Well, Paul himself stated that according to their lawyer department, > > "Copyright" (which is there) is enough. So it made sense to remove invalid > > (at least in some sense) character. > > > > Also zillion of other files copyrighted by Paul contain "Copyright (C)". > > > > If we really want this character there then, why not rather in UTF-8, so > > that it works flawlessly? > > It might be fine but i havent seen Paul reply to this thread - and this is my > point: _you_ should have waited for an ack from Paul (who is co-maintaining > that file) before applying it. The commit doesnt have it: I got Pauls reply as "as soon as there is `Copyright', it's fine". If I misunderstood it, sorry for that, and I'll drop the patch. Paul, could you please send explicit Acked-by: or Naked-by:, so that everything is in line? Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Harald Arnesen on 30 Apr 2010 13:50 Tejun Heo <tj(a)kernel.org> writes: > On 04/28/2010 08:42 PM, Harald Arnesen wrote: >> Tejun Heo <tj(a)kernel.org> writes: >> >>> The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and >>> causes annoying problems with some editors and tools. Use (C) >>> instead. >> >> Why do we need anything there at all? > > We don't necessarily need it but it's also pretty rude to strip > other's copyright notices and other entries use (C), so.... :-) I meant that: Copyright © somename Copyright (C) somename Copyright somename all have the same legal meaning. -- Hilsen Harald. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ingo Molnar on 30 Apr 2010 14:10 * Jiri Kosina <jkosina(a)suse.cz> wrote: > On Fri, 30 Apr 2010, Ingo Molnar wrote: > > > > Well, Paul himself stated that according to their lawyer department, > > > "Copyright" (which is there) is enough. So it made sense to remove invalid > > > (at least in some sense) character. > > > > > > Also zillion of other files copyrighted by Paul contain "Copyright (C)". > > > > > > If we really want this character there then, why not rather in UTF-8, so > > > that it works flawlessly? > > > > It might be fine but i havent seen Paul reply to this thread - and this is my > > point: _you_ should have waited for an ack from Paul (who is co-maintaining > > that file) before applying it. The commit doesnt have it: > > I got Pauls reply as "as soon as there is `Copyright', it's fine". [...] If lkml was not Cc:-ed to that reply (which appears to be the case) then it's worth asking for / waiting for an explicit ack. > [...] If I misunderstood it, sorry for that, and I'll drop the patch. > > Paul, could you please send explicit Acked-by: or Naked-by:, so that > everything is in line? And in that case my NAK is moot. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ingo Molnar on 30 Apr 2010 14:20 * Jiri Kosina <jkosina(a)suse.cz> wrote: > On Wed, 28 Apr 2010, Tejun Heo wrote: > > > The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and > > causes annoying problems with some editors and tools. Use (C) > > instead. > > > > Signed-off-by: Tejun Heo <tj(a)kernel.org> > > Cc: Paul Mackerras <paulus(a)au1.ibm.com> > > --- > > I'm not really sure this would survive transport over mail in > > appliable form, attaching the patch too just in case. > > It didn't survive :) But it was easy enough to fix by hand. Applied, > thanks Tejun. NAK. A similar patch was sent a few weeks ago, it was objected to and rejected - the copyright character was used for legal reasons. Jiri, in the future please dont apply 'trivial' patches that involve subsystems that i co-maintain and which is not acked by any of the subsystem maintainers. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ingo Molnar on 30 Apr 2010 15:00 * Jiri Kosina <jkosina(a)suse.cz> wrote: > On Fri, 30 Apr 2010, Ingo Molnar wrote: > > > > > The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and > > > > causes annoying problems with some editors and tools. Use (C) > > > > instead. > > > > > > > > Signed-off-by: Tejun Heo <tj(a)kernel.org> > > > > Cc: Paul Mackerras <paulus(a)au1.ibm.com> > > > > --- > > > > I'm not really sure this would survive transport over mail in > > > > appliable form, attaching the patch too just in case. > > > > > > It didn't survive :) But it was easy enough to fix by hand. Applied, > > > thanks Tejun. > > > > NAK. > > > > A similar patch was sent a few weeks ago, it was objected to and rejected - > > the copyright character was used for legal reasons. > > Well, Paul himself stated that according to their lawyer department, > "Copyright" (which is there) is enough. So it made sense to remove invalid > (at least in some sense) character. > > Also zillion of other files copyrighted by Paul contain "Copyright (C)". > > If we really want this character there then, why not rather in UTF-8, so > that it works flawlessly? It might be fine but i havent seen Paul reply to this thread - and this is my point: _you_ should have waited for an ack from Paul (who is co-maintaining that file) before applying it. The commit doesnt have it: commit 62006c58a9a2d8b72b5b65301965bc444d43e22c Author: Tejun Heo <tj(a)kernel.org> Date: Wed Apr 28 11:30:31 2010 +0200 trivial: use (C) instead of \251 The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead. Signed-off-by: Tejun Heo <tj(a)kernel.org> Cc: Paul Mackerras <paulus(a)au1.ibm.com> Signed-off-by: Jiri Kosina <jkosina(a)suse.cz> We dont just go and change people's copyright notices, no matter how trivial it may seem ... Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
First
|
Prev
|
Next
|
Last
Pages: 1 2 3 Prev: drivers/staging/rtl8192su: Hoist assign from if Next: sched: implement the exclusive wait queue as a LIFO queue |