Prev: drivers/staging/rtl8192su: Hoist assign from if
Next: sched: implement the exclusive wait queue as a LIFO queue
From: Harald Arnesen on 28 Apr 2010 14:50
Tejun Heo <tj(a)kernel.org> writes:

> The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and
> causes annoying problems with some editors and tools. Use (C)
> instead.

Why do we need anything there at all?
--
Hilsen Harald.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tejun Heo on 28 Apr 2010 16:30
On 04/28/2010 08:42 PM, Harald Arnesen wrote:
> Tejun Heo <tj(a)kernel.org> writes:
>
>> The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and
>> causes annoying problems with some editors and tools. Use (C)
>> instead.
>
> Why do we need anything there at all?

We don't necessarily need it but it's also pretty rude to strip
other's copyright notices and other entries use (C), so.... :-)

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Kosina on 28 Apr 2010 18:50
On Wed, 28 Apr 2010, Tejun Heo wrote:

> The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and
> causes annoying problems with some editors and tools. Use (C)
> instead.
>
> Signed-off-by: Tejun Heo <tj(a)kernel.org>
> Cc: Paul Mackerras <paulus(a)au1.ibm.com>
> ---
> I'm not really sure this would survive transport over mail in
> appliable form, attaching the patch too just in case.

It didn't survive :) But it was easy enough to fix by hand. Applied,
thanks Tejun.

> kernel/perf_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index 2f3fbf8..827ec53 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -4,7 +4,7 @@
> * Copyright (C) 2008 Thomas Gleixner <tglx(a)linutronix.de>
> * Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar
> * Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <pzijlstr(a)redhat.com>
> - * Copyright � 2009 Paul Mackerras, IBM Corp. <paulus(a)au1.ibm.com>
> + * Copyright (C) 2009 Paul Mackerras, IBM Corp. <paulus(a)au1.ibm.com>
> *
> * For licensing details see kernel-base/COPYING
> */
>

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Kosina on 30 Apr 2010 12:50
On Fri, 30 Apr 2010, Ingo Molnar wrote:

> > > The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and
> > > causes annoying problems with some editors and tools. Use (C)
> > > instead.
> > >
> > > Signed-off-by: Tejun Heo <tj(a)kernel.org>
> > > Cc: Paul Mackerras <paulus(a)au1.ibm.com>
> > > ---
> > > I'm not really sure this would survive transport over mail in
> > > appliable form, attaching the patch too just in case.
> >
> > It didn't survive :) But it was easy enough to fix by hand. Applied,
> > thanks Tejun.
>
> NAK.
>
> A similar patch was sent a few weeks ago, it was objected to and rejected -
> the copyright character was used for legal reasons.

Well, Paul himself stated that according to their lawyer department,
"Copyright" (which is there) is enough. So it made sense to remove invalid
(at least in some sense) character.

Also zillion of other files copyrighted by Paul contain "Copyright (C)".

If we really want this character there then, why not rather in UTF-8, so
that it works flawlessly?

> Jiri, in the future please dont apply 'trivial' patches that involve
> subsystems that i co-maintain and which is not acked by any of the subsystem
> maintainers.

OK, as you wish.

--
Jiri Kosina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Paul Mackerras on 30 Apr 2010 13:00

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 |  Next  |  Last
Pages: 1 2 3
Prev: drivers/staging/rtl8192su: Hoist assign from if
Next: sched: implement the exclusive wait queue as a LIFO queue